[PATCH 2/5] d3d8/tests: Test device caps on multiple adapters.
hverbeet at gmail.com
Mon Mar 16 08:44:49 CDT 2020
On Mon, 16 Mar 2020 at 16:53, Zhiyi Zhang <zzhang at codeweavers.com> wrote:
> On 3/16/20 8:02 PM, Henri Verbeet wrote:
> > On Fri, 13 Mar 2020 at 13:06, Zhiyi Zhang <zzhang at codeweavers.com> wrote:
> >> -static IDirect3DDevice8 *create_device(IDirect3D8 *d3d8, HWND focus_window, const struct device_desc *desc)
> >> +static IDirect3DDevice8 *create_device_on_adapter(IDirect3D8 *d3d8, unsigned int adapter_idx,
> >> + HWND focus_window, const struct device_desc *desc)
> > Introducing an extra function works, but I think I'd prefer adding a
> > field for the adapter to the existing device_desc structure.
> Well. That would introduce a lot of diffs because a NULL can not be passed to 'desc' any more.
If it's NULL, we'd use D3DADAPTER_DEFAULT; we have other default values as well.
> > You're not printing the adapter index in the ok() messages here.
> adapter index for every ok() messages in the loop?
More information about the wine-devel