[PATCH v10 1/4] jscript: Get rid of the variable_obj parameter to exec_source.
Gabriel Ivăncescu
gabrielopcode at gmail.com
Tue Mar 17 07:59:27 CDT 2020
Hi Jacek,
On 16/03/2020 20:32, Jacek Caban wrote:
> On 12.03.2020 18:11, Gabriel Ivăncescu wrote:
>> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
>> ---
>> dlls/jscript/engine.c | 39 +++++++++++++++++++++++++++++----------
>> dlls/jscript/engine.h | 2 +-
>> dlls/jscript/function.c | 6 ++----
>> dlls/jscript/global.c | 2 +-
>> dlls/jscript/jscript.c | 6 +++---
>> 5 files changed, 36 insertions(+), 19 deletions(-)
>
>
> This patch breaks tests.
Sorry for delay, but what tests does it break exactly? I'm not getting
any failures. I tried mshtml_test script too.
> Also, what was the exact problem with handling
> EXEC_RETURN_TO_INTERP?
>
If I add a check for that flag on top of EXEC_EVAL, I get failures in
jscript/run.c test_eval:
run.c:2931: Test failed: GetDispID(x) returned 00000000
run.c:2931: Test failed: GetDispID(x) returned 00000000
Thanks,
Gabriel
More information about the wine-devel
mailing list