[PATCH v2] winecfg: don't trash app names

Zebediah Figura z.figura12 at gmail.com
Wed Mar 18 13:33:48 CDT 2020

On 3/18/20 12:58 PM, Rafał Mużyło wrote:
>   Currently, if app name isn't representable in CP_ACP, it gets trashed
>   during creation. There's no reason for it - the name is originally
>   retrived as widechar string. This isn't the cleanest way, but still one
>   that works.
>   gothas: enumerate_values is no longer usable for other maens, yet this
>   was its only use; reg_key_exists becomes unused; {g,s}et_app_reg_key
>   copy a lot of existing code, instead of reusing
>   minor note: winecfg could use a better check for KEY_WOW64_32KEY case -
>   in my experience, it's quite often that key created by winecfg should
>   actually under Wow6432Node, otherwise it has no effect.
>   v2: no real changes, just a cast to silence a warning and a non-patch
>   bit I've missed
> Signed-off-by: Rafał Mużyło <galtgendo at o2.pl>

It seems to me like it'd be simpler just to do everything in Unicode.

More information about the wine-devel mailing list