[PATCH v2] user32/tests: Update 1 todo_wine message in msg.

Zebediah Figura z.figura12 at gmail.com
Thu Mar 19 11:35:57 CDT 2020


On 3/19/20 10:22 AM, Serge Gautherie wrote:
> Signed-off-by: Serge Gautherie <winehq-git_serge_180711 at gautherie.fr>
> ---
> For the record, debian10 and debiant results:
> https://testbot.winehq.org/JobDetails.pl?Key=67492
> ---
>  dlls/user32/tests/msg.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
> index 303a026..adca844 100644
> --- a/dlls/user32/tests/msg.c
> +++ b/dlls/user32/tests/msg.c
> @@ -2396,9 +2396,8 @@ static void dump_sequence(const struct message *expected, const char *context, c
>      }
>  }
>  
> -#define ok_sequence( exp, contx, todo) \
> -        ok_sequence_( (exp), (contx), (todo), __FILE__, __LINE__)
> -
> +#define ok_sequence(exp, contx, todo) \
> +    ok_sequence_(exp, contx, todo, __FILE__, __LINE__)
>  
>  static void ok_sequence_(const struct message *expected_list, const char *context, BOOL todo,
>                           const char *file, int line)
> @@ -2571,10 +2570,11 @@ static void ok_sequence_(const struct message *expected_list, const char *contex
>                                context, count, expected->message, actual->message);
>          }
>      }
> +
>      if( todo && !failcount) /* succeeded yet marked todo */
>          todo_wine {
>              if (!strcmp(winetest_platform, "wine")) dump++;
> -            ok_( file, line)( TRUE, "%s: marked \"todo_wine\" but succeeds\n", context);
> +            ok_(file, line)(TRUE, "%s, (line %d)\n", context, __LINE__);
>          }
>  
>  done:

You probably should try to avoid these stray whitespace changes; they're
pointless and unrelated to the subject of the patch.

> @@ -5153,7 +5153,7 @@ static void test_messages(void)
>  
>      ShowWindow(hwnd, SW_MINIMIZE);
>      flush_events();
> -    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
> +    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped [Not fixed, though ok on TestBot]", TRUE);
>      flush_sequence();
>  
>      if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)
> 

I'm not sure that I see the value of this.



More information about the wine-devel mailing list