[PATCH 1/2] gdiplus: Don't test font face of DEFAULT_GUI_FONT.

Jeff Smith whydoubt at gmail.com
Sun Mar 22 20:14:21 CDT 2020


On Sun, Mar 22, 2020, 2:46 PM Esme <vincent at codeweavers.com> wrote:

> From: Vincent Povirk <vincent at codeweavers.com>
>
> Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=47872
> Signed-off-by: Vincent Povirk <vincent at codeweavers.com>
> ---
>  dlls/gdiplus/tests/font.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c
> index 9abb80faaf5..7f4b1e876e5 100644
> --- a/dlls/gdiplus/tests/font.c
> +++ b/dlls/gdiplus/tests/font.c
> @@ -808,29 +808,21 @@ static void test_font_metrics(void)
>
>  static void test_font_substitution(void)
>  {
> -    WCHAR ms_shell_dlg[LF_FACESIZE];
> +    const WCHAR ms_shell_dlg[] = {'M','S',' ','S','h','e','l','l','
> ','D','l','g',0};


Especially for tests, is there any reason now to avoid using L””-style
literals for wchar strings?

If not, you could get rid of ms_shell_dlg completely and substitute L"MS
Shell Dlg" for the one remaining place ms_shell_dlg is used.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200322/454a16de/attachment.htm>


More information about the wine-devel mailing list