[PATCH 3/5] jscript/tests: Add tests for persistent named items.
Jacek Caban
jacek at codeweavers.com
Mon Mar 23 19:38:41 CDT 2020
Hi Gabriel,
On 23.03.2020 14:53, Gabriel Ivăncescu wrote:
> SET_EXPECT(OnStateChange_CONNECTED);
> - SET_EXPECT_MULTI(OnEnterScript, 4);
> - SET_EXPECT_MULTI(OnLeaveScript, 4);
> + SET_EXPECT_MULTI(OnEnterScript, 5);
> + SET_EXPECT_MULTI(OnLeaveScript, 5);
> + SET_EXPECT(GetIDsOfNames);
> hr = IActiveScript_SetScriptState(script, SCRIPTSTATE_CONNECTED);
> ok(hr == S_OK, "SetScriptState(SCRIPTSTATE_CONNECTED) failed: %08x\n", hr);
> CHECK_CALLED(OnStateChange_CONNECTED);
> - CHECK_CALLED_MULTI(OnEnterScript, 4);
> - CHECK_CALLED_MULTI(OnLeaveScript, 4);
> + CHECK_CALLED_MULTI(OnEnterScript, 5);
> + CHECK_CALLED_MULTI(OnLeaveScript, 5);
> + todo_wine CHECK_CALLED(GetIDsOfNames);
> test_state(script, SCRIPTSTATE_CONNECTED);
Before this patch that code verified that GetIDsOfNames is not called
for any code. Now, after your change, it does no longer does that.
Please try to move the test into a separated pass instead of mixing all
tests together.
Thanks,
Jacek
More information about the wine-devel
mailing list