[PATCH] dinput: Fix crash in dump_DIEFFECT() when rglDirection is unexpectedly NULL.

Brendan Shanks bshanks at codeweavers.com
Tue Mar 24 19:13:36 CDT 2020


Signed-off-by: Brendan Shanks <bshanks at codeweavers.com>
---
 dlls/dinput/joystick.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c
index 01611b0e44..19dd9ad736 100644
--- a/dlls/dinput/joystick.c
+++ b/dlls/dinput/joystick.c
@@ -207,7 +207,7 @@ void dump_DIEFFECT(LPCDIEFFECT eff, REFGUID guid, DWORD dwFlags)
     TRACE("  - dwTriggerButton: %d\n", eff->dwTriggerButton);
     TRACE("  - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval);
     TRACE("  - rglDirection: %p\n", eff->rglDirection);
-    if (dwFlags & DIEP_DIRECTION) {
+    if (dwFlags & DIEP_DIRECTION && eff->rglDirection) {
         TRACE("    ");
         for (i = 0; i < eff->cAxes; ++i)
             TRACE("%d ", eff->rglDirection[i]);
-- 
2.24.1




More information about the wine-devel mailing list