[PATCH 2/5] d3dcompiler: Get rid of the init_*_dx9_writer() helpers.

Zebediah Figura zfigura at codeweavers.com
Wed Mar 25 16:43:47 CDT 2020


On 3/25/20 4:25 PM, Matteo Bruni wrote:
> On Wed, Mar 25, 2020 at 1:19 AM Zebediah Figura <z.figura12 at gmail.com> wrote:
>>
> 
> I get:
> /home/matteo/wine/dlls/d3dcompiler_43/bytecodewriter.c:2291:5: error:
> unknown type name ‘uint8_t’
>  2291 |     uint8_t major, minor;
>       |     ^~~~~~~
> 
> Looks very nice otherwise.
> BTW:
> 

Eh, that was left over from 181423, but Alexandre seems to have fixed
that up to "unsigned char".

Alexandre, not that there's much value in using uint8_t here, but what's
the rationale for avoiding it?

>> @@ -2443,17 +2342,32 @@ HRESULT shader_write_bytecode(const struct bwriter_shader *shader, DWORD **resul
>>          ERR("NULL shader structure, aborting\n");
>>          return E_FAIL;
>>      }
>> -    writer = create_writer(sm1_version(shader));
>> -    writer->shader = shader;
>> -    *result = NULL;
>>
>> -    if(!writer) {
> 
> Nice NULL check we had here :/
> 

I thought so too :D



More information about the wine-devel mailing list