[PATCH 2/2] dmime: Record DMUS_IO_TRACK_EXTRAS_HEADER information with track

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Wed Mar 25 17:04:57 CDT 2020


Hi Michael,

On 26/3/20 8:44 am, Michael Stefaniuc wrote:
> Hello AListair,
> 
> do you have more in this series?
Not at this stage, but the next one was going to be SetTrackConfig, 
which will require at least the flags to be stored.

> And no clue what the dwPriority is for. The only priority stuff I can
> find is for the channels.
I noticed that as well, there isn't much documentation about dwPriority 
but thought to store as well, so the fixme could be removed.

> 
> So most likely we will need a helper for InsertTrack() that either
> returns the index in the corresponding group or a
> LPDMUS_PRIVATE_SEGMENT_TRACK.
> But I wouldn't bother to store the info if we don't know how to use it.
> 
I agree, a helper for InsertTrack would be useful.  The storing of flags 
makes sense to me at least, eg. DMUS_TRACKCONFIG_PLAY_ENABLED, as they 
should be used once track looping is implemented.

Regards
Alistair.


More information about the wine-devel mailing list