[PATCH] comctl32: Initialize early some edit control properties.

Nikolay Sivov nsivov at codeweavers.com
Thu Mar 26 04:01:40 CDT 2020

On 3/25/20 2:12 PM, Roman Pišl wrote:
> Hello Nikolay,
> bug 37144 is also marked as user32 and closed as duplicate of 19239 
> but also fixed by this. Should I mention the bug 37144 in commit 
> message or will be properly re-closed in bugzilla?
> My thought was - make the initialization early, it can't hurt 
> anything, but it is also obvious that EDIT_EM_EmptyUndoBuffer is 
> useless - the buffer is already zeroed by heap_alloc_zero() so the 
> removal is intentional. Should I put it back to WM_Create?
> Ok, will prepare tests.

I've attached test diff to https://bugs.winehq.org/show_bug.cgi?id=48803 
after your comment, which shows that moving initialization earlier has 
side effects.

> Thanks
> Roman
> Dne 25. 03. 20 v 11:52 Nikolay Sivov napsal(a):
>> Please add a test that crashes without this change. Bug 19239 is 
>> linked to user32, so that should be addressed separately.
>> P.S. there is no need to more comment, or to remove 
>> EDIT_EM_EmptyUndoBuffer().

More information about the wine-devel mailing list