[PATCH 1/5] ddraw: Silence enumeration conversion warnings. (Clang)

Henri Verbeet hverbeet at gmail.com
Thu Mar 26 10:31:47 CDT 2020


On Thu, 26 Mar 2020 at 12:16, Chip Davis <cdavis at codeweavers.com> wrote:
>
> *We* know that these enums are equivalent, but Clang doesn't. So, tell
> Clang that it shouldn't care.
>
> The remaining warnings are due to a bug in Clang around unions with enum
> types.
>
I'm not sure this is really worth fixing (as opposed to just disabling
the corresponding warning for Clang), but if we do, I'd prefer
introducing conversion helpers along the lines of
wined3dformat_from_ddrawformat(),
wined3dmapflags_from_ddrawmapflags(), etc. You can of course still
implement those by doing a cast, but I'd prefer not sprinkling those
casts around the code.



More information about the wine-devel mailing list