[PATCH] include/d3d9: add missing interfaces

Henri Verbeet hverbeet at gmail.com
Fri Mar 27 13:12:15 CDT 2020

On Tue, 24 Mar 2020 at 19:38, Biswapriyo Nath <nathbappai at gmail.com> wrote:
I seem to have missed this patch getting assigned to me.

First, could we please get a more descriptive commit message? That may
be easier if you split the patch into several patches each only
introducing a single interface. Second, do you happen to have an
application that needs these interfaces to build against the Wine
headers? If they're for internal Wine usage instead, it may make more
sense to introduce them together with the code that uses them.

> +    STDMETHOD(GetCertificate)(THIS_ UINT CertifacteSize, BYTE *ppCertificate) PURE;
Please use reasonable parameter names; e.g., "certificate_size",
"certificate". The existing code in that header isn't necessarily a
great example in that regard, but we try to improve things.

More information about the wine-devel mailing list