[PATCH v2 2/6] winedbg: Force packet data to be NUL terminated.

Rémi Bernon rbernon at codeweavers.com
Tue Mar 31 08:12:27 CDT 2020


Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
 programs/winedbg/gdbproxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/winedbg/gdbproxy.c b/programs/winedbg/gdbproxy.c
index e2954c08dddf..fde6c556c26d 100644
--- a/programs/winedbg/gdbproxy.c
+++ b/programs/winedbg/gdbproxy.c
@@ -1201,7 +1201,6 @@ static enum packet_return packet_read_memory(struct gdb_context* gdbctx)
     SIZE_T              r = 0;
 
     assert(gdbctx->in_trap);
-    /* FIXME:check in_packet_len for reading %p,%x */
     if (sscanf(gdbctx->in_packet, "%p,%x", &addr, &len) != 2) return packet_error;
     if (len <= 0) return packet_error;
     TRACE("Read %u bytes at %p\n", len, addr);
@@ -1794,6 +1793,7 @@ static BOOL extract_packets(struct gdb_context* gdbctx)
                 {
                     gdbctx->in_packet = gdbctx->in_buf + 2;
                     gdbctx->in_packet_len = plen - 1;
+                    gdbctx->in_packet[gdbctx->in_packet_len] = '\0';
                     ret = (packet_entries[i].handler)(gdbctx);
                 }
                 switch (ret & ~packet_last_f)
-- 
2.26.0.rc2




More information about the wine-devel mailing list