[PATCH 01/10] d3d8/test: Avoid abs() on unsigned values in compare_mode().

Henri Verbeet hverbeet at codeweavers.com
Tue Mar 31 10:09:11 CDT 2020


From: Chip Davis <cdavis at codeweavers.com>

Mostly because Clang complains.

Signed-off-by: Chip Davis <cdavis at codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
---
 dlls/d3d8/tests/device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c
index d87832b716d..26687af5f15 100644
--- a/dlls/d3d8/tests/device.c
+++ b/dlls/d3d8/tests/device.c
@@ -1294,8 +1294,8 @@ static int compare_mode(const void *a, const void *b)
 {
     const struct mode *mode_a = a;
     const struct mode *mode_b = b;
-    unsigned int w = mode_a->w - mode_b->w;
-    unsigned int h = mode_a->h - mode_b->h;
+    int w = mode_a->w - mode_b->w;
+    int h = mode_a->h - mode_b->h;
     return abs(w) >= abs(h) ? -w : -h;
 }
 
-- 
2.20.1




More information about the wine-devel mailing list