[PATCH 2/3] ddraw: Properly compare DDENUMSURFACES_NOMATCH to TRUE.
Zebediah Figura
z.figura12 at gmail.com
Sat May 2 21:45:52 CDT 2020
Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
---
dlls/ddraw/ddraw.c | 8 ++++----
dlls/ddraw/tests/ddraw1.c | 2 +-
dlls/ddraw/tests/ddraw2.c | 2 +-
dlls/ddraw/tests/ddraw4.c | 2 +-
dlls/ddraw/tests/ddraw7.c | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c
index b7e7e6514a8..afd2875ea21 100644
--- a/dlls/ddraw/ddraw.c
+++ b/dlls/ddraw/ddraw.c
@@ -3213,7 +3213,7 @@ static HRESULT CALLBACK EnumSurfacesCallbackThunk(IDirectDrawSurface7 *surface,
* DD_OK on success
*
*****************************************************************************/
-static HRESULT WINAPI ddraw7_EnumSurfaces(IDirectDraw7 *iface, DWORD Flags,
+static HRESULT WINAPI ddraw7_EnumSurfaces(IDirectDraw7 *iface, DWORD flags,
DDSURFACEDESC2 *DDSD, void *Context, LPDDENUMSURFACESCALLBACK7 Callback)
{
struct ddraw *ddraw = impl_from_IDirectDraw7(iface);
@@ -3223,10 +3223,10 @@ static HRESULT WINAPI ddraw7_EnumSurfaces(IDirectDraw7 *iface, DWORD Flags,
struct list *entry, *entry2;
TRACE("iface %p, flags %#x, surface_desc %p, context %p, callback %p.\n",
- iface, Flags, DDSD, Context, Callback);
+ iface, flags, DDSD, Context, Callback);
- all = Flags & DDENUMSURFACES_ALL;
- nomatch = Flags & DDENUMSURFACES_NOMATCH;
+ all = flags & DDENUMSURFACES_ALL;
+ nomatch = !!(flags & DDENUMSURFACES_NOMATCH);
if (!Callback)
return DDERR_INVALIDPARAMS;
diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c
index 34ebfab1b7b..4e620b4a905 100644
--- a/dlls/ddraw/tests/ddraw1.c
+++ b/dlls/ddraw/tests/ddraw1.c
@@ -12226,7 +12226,7 @@ static void test_enum_surfaces(void)
hr = IDirectDraw_EnumSurfaces(ddraw, DDENUMSURFACES_DOESEXIST | DDENUMSURFACES_NOMATCH,
&desc, ¶m, enum_surfaces_cb);
ok(hr == DD_OK, "Failed to enumerate surfaces, hr %#x.\n", hr);
- todo_wine ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
+ ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
desc.dwFlags = 0;
param.count = 0;
diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c
index 90f7b77c839..3172948d335 100644
--- a/dlls/ddraw/tests/ddraw2.c
+++ b/dlls/ddraw/tests/ddraw2.c
@@ -13202,7 +13202,7 @@ static void test_enum_surfaces(void)
hr = IDirectDraw2_EnumSurfaces(ddraw, DDENUMSURFACES_DOESEXIST | DDENUMSURFACES_NOMATCH,
&desc, ¶m, enum_surfaces_cb);
ok(hr == DD_OK, "Failed to enumerate surfaces, hr %#x.\n", hr);
- todo_wine ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
+ ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
desc.dwFlags = 0;
param.count = 0;
diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c
index 8012e10a19c..fb14f281e20 100644
--- a/dlls/ddraw/tests/ddraw4.c
+++ b/dlls/ddraw/tests/ddraw4.c
@@ -15790,7 +15790,7 @@ static void test_enum_surfaces(void)
hr = IDirectDraw4_EnumSurfaces(ddraw, DDENUMSURFACES_DOESEXIST | DDENUMSURFACES_NOMATCH,
&desc, ¶m, enum_surfaces_cb);
ok(hr == DD_OK, "Failed to enumerate surfaces, hr %#x.\n", hr);
- todo_wine ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
+ ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
desc.dwFlags = 0;
param.count = 0;
diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c
index d94676ba5e6..459869ad869 100644
--- a/dlls/ddraw/tests/ddraw7.c
+++ b/dlls/ddraw/tests/ddraw7.c
@@ -15200,7 +15200,7 @@ static void test_enum_surfaces(void)
hr = IDirectDraw7_EnumSurfaces(ddraw, DDENUMSURFACES_DOESEXIST | DDENUMSURFACES_NOMATCH,
&desc, ¶m, enum_surfaces_cb);
ok(hr == DD_OK, "Failed to enumerate surfaces, hr %#x.\n", hr);
- todo_wine ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
+ ok(param.count == 2, "Got unexpected number of enumerated surfaces %u.\n", param.count);
desc.dwFlags = 0;
param.count = 0;
--
2.26.2
More information about the wine-devel
mailing list