[PATCH 2/3] winevulkan: Avoid adding duplicate enum aliases.

[Liam Middlebrook]

On 5/4/20 11:29 AM, Philip Rebohle wrote:
> VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_ID_PROPERTIES_KHR is being
> defined multiple times by the current vk.xml.
> 
> Signed-off-by: Philip Rebohle <philip.rebohle at tu-dortmund.de>
> ---
>   dlls/winevulkan/make_vulkan | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan
> index e24dac99011..36181e101fc 100755
> --- a/dlls/winevulkan/make_vulkan
> +++ b/dlls/winevulkan/make_vulkan
> @@ -395,7 +395,9 @@ class VkEnum(object):
>               if not value.is_alias() and v.value == value.value:
>                   LOGGER.debug("Adding duplicate enum value {0} to {1}".format(v, self.name))
>                   return
> -        self.values.append(value)

Nitpick: I think this should be aligned with the if statement below it


Thanks,

Liam Middlebrook

> +	# Avoid adding duplicate aliases multiple times
> +        if not any(x.name == value.name for x in self.values):
> +            self.values.append(value)
>   
>       def definition(self):
>           if self.is_alias():
> 

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------