[PATCH v2 2/2] dmime: Parse Wave track stream

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Thu May 7 23:13:49 CDT 2020


Hi Michael

On 8/5/20 7:55 am, Michael Stefaniuc wrote:
> Hello Alistair,
> 
> this patch produces heavy -Wformat warnings in the TRACEs.
> And does this code work?
> You're not parsing anything out with dmobj_parsedescriptor() as it gets
> as 'supported' only DMUS_OBJ_CLASS.

This worked as expected, the reference.dwValidData appears to contain 
all the fields we parse in dmobj_parsedescriptor.  The bug that I see, 
is that dwValidData is reset and is missing the DMUS_OBJ_CLASS flag 
which we assigned before the function.

Regards
Alistair.






More information about the wine-devel mailing list