[v3 PATCH] dxgi: Translate DXGI_USAGE_UNORDERED_ACCESS to corresponding wined3d bind flag.

Dmitry Timoshkov dmitry at baikal.ru
Sat May 9 08:13:35 CDT 2020


Nikolay Sivov <nsivov at codeweavers.com> wrote:

> +    hr = pD3D11CreateDevice(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, feature_level, feature_level_count,
> +            D3D11_SDK_VERSION, &d3d_device, NULL, NULL);
> +    if (FAILED(hr))
> +        hr = pD3D11CreateDevice(NULL, D3D_DRIVER_TYPE_WARP, NULL, 0, feature_level, feature_level_count,
> +                D3D11_SDK_VERSION, &d3d_device, NULL, NULL);
> +    if (FAILED(hr))
> +        hr = pD3D11CreateDevice(NULL, D3D_DRIVER_TYPE_REFERENCE, NULL, 0, feature_level, feature_level_count,
> +                D3D11_SDK_VERSION, &d3d_device, NULL, NULL);
> +
> +    if (SUCCEEDED(hr))
> +    {
> +        hr = ID3D11Device_QueryInterface(d3d_device, &IID_IDXGIDevice, (void **)&device);

ok() is missing.

> +        ID3D11Device_Release(d3d_device);
> +    }

It would be much better to consistently check for S_OK if other values
covered by SUCCEEDED/FAILED are not supposed to be accepted.

-- 
Dmitry.



More information about the wine-devel mailing list