[PATCH v3 2/4] d3d11: Downgrade FIXME on immediate GetContextFlags() to a WARN.

Chip Davis cdavis at codeweavers.com
Thu May 14 14:52:47 CDT 2020


This returns the flags that were passed to
ID3D11Device::CreateDeferredContext(). It has no meaning for immediate
contexts, and there are no flags defined anyway.

Signed-off-by: Chip Davis <cdavis at codeweavers.com>
---
v3: Unchanged from v2.
---
 dlls/d3d11/device.c      | 2 +-
 dlls/d3d11/tests/d3d11.c | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c
index 01b32002408..207d3869c27 100644
--- a/dlls/d3d11/device.c
+++ b/dlls/d3d11/device.c
@@ -2408,7 +2408,7 @@ static D3D11_DEVICE_CONTEXT_TYPE STDMETHODCALLTYPE d3d11_immediate_context_GetTy
 
 static UINT STDMETHODCALLTYPE d3d11_immediate_context_GetContextFlags(ID3D11DeviceContext1 *iface)
 {
-    FIXME("iface %p stub!\n", iface);
+    WARN("iface %p called on immediate context.\n", iface);
 
     return 0;
 }
diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c
index 90dadf84149..7caae08816a 100644
--- a/dlls/d3d11/tests/d3d11.c
+++ b/dlls/d3d11/tests/d3d11.c
@@ -30070,6 +30070,7 @@ static void test_deferred_methods_on_immediate_context(void)
     ID3D11CommandList *command_list;
     ID3D11Buffer *buffer[2];
     ID3D11Device *device;
+    unsigned int flags;
     HRESULT hr;
 
     if (!(device = create_device(NULL)))
@@ -30080,6 +30081,9 @@ static void test_deferred_methods_on_immediate_context(void)
 
     ID3D11Device_GetImmediateContext(device, &immediate_context);
 
+    flags = ID3D11DeviceContext_GetContextFlags(immediate_context);
+    ok(flags == 0, "Immediate context has flags %#x.\n", flags);
+
     hr = ID3D11DeviceContext_FinishCommandList(immediate_context, FALSE, &command_list);
     ok(hr == DXGI_ERROR_INVALID_CALL, "Immediate FinishCommandList returned hr %#x.\n", hr);
 
-- 
2.24.0




More information about the wine-devel mailing list