[PATCH 4/4] d3d11: Stop advertising ID3D10Device interface.
Rémi Bernon
rbernon at codeweavers.com
Fri May 15 07:08:19 CDT 2020
UPlay overlay tries to detect the device D3D version by querying this
interface first. On D3D11 games, and as we are incorrectly advertising
ID3D10Device, it decides to use D3D10 hooks and crashes the game after
~10 minutes.
This is happening with Splinter Cell: Blacklist for instance.
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
dlls/d3d11/d3d11_main.c | 8 ++++++++
dlls/d3d11/d3d11_private.h | 6 ++++++
dlls/d3d11/device.c | 6 ++++--
dlls/d3d11/tests/d3d11.c | 16 ++++++++--------
4 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/dlls/d3d11/d3d11_main.c b/dlls/d3d11/d3d11_main.c
index a5854a93cc31..65bb14b49d01 100644
--- a/dlls/d3d11/d3d11_main.c
+++ b/dlls/d3d11/d3d11_main.c
@@ -107,6 +107,7 @@ HRESULT WINAPI D3D11CoreRegisterLayers(void)
HRESULT WINAPI D3D11CoreCreateDevice(IDXGIFactory *factory, IDXGIAdapter *adapter, UINT flags,
const D3D_FEATURE_LEVEL *feature_levels, UINT levels, ID3D11Device **device)
{
+ struct d3d_device *d3d_device;
IUnknown *dxgi_device;
HMODULE d3d11;
HRESULT hr;
@@ -130,6 +131,13 @@ HRESULT WINAPI D3D11CoreCreateDevice(IDXGIFactory *factory, IDXGIAdapter *adapte
return E_FAIL;
}
+ if (!(d3d_device = impl_from_ID3D11Device(*device)))
+ {
+ ERR("Failed to retrieve device impl, returning E_FAIL.\n");
+ return E_FAIL;
+ }
+ d3d_device->d3d11_only = 1;
+
return S_OK;
}
diff --git a/dlls/d3d11/d3d11_private.h b/dlls/d3d11/d3d11_private.h
index 48c76959fae0..8ac2d5285045 100644
--- a/dlls/d3d11/d3d11_private.h
+++ b/dlls/d3d11/d3d11_private.h
@@ -537,6 +537,7 @@ struct d3d_device
LONG refcount;
D3D_FEATURE_LEVEL feature_level;
+ int d3d11_only;
struct d3d11_immediate_context immediate_context;
@@ -552,6 +553,11 @@ struct d3d_device
UINT stencil_ref;
};
+static inline struct d3d_device *impl_from_ID3D11Device(ID3D11Device *iface)
+{
+ return CONTAINING_RECORD((ID3D11Device2 *)iface, struct d3d_device, ID3D11Device2_iface);
+}
+
static inline struct d3d_device *impl_from_ID3D11Device2(ID3D11Device2 *iface)
{
return CONTAINING_RECORD(iface, struct d3d_device, ID3D11Device2_iface);
diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c
index 7544bc86f4bc..0be722c0189d 100644
--- a/dlls/d3d11/device.c
+++ b/dlls/d3d11/device.c
@@ -3881,8 +3881,9 @@ static HRESULT STDMETHODCALLTYPE d3d_device_inner_QueryInterface(IUnknown *iface
{
*out = &device->ID3D11Device2_iface;
}
- else if (IsEqualGUID(riid, &IID_ID3D10Device1)
- || IsEqualGUID(riid, &IID_ID3D10Device))
+ else if (!device->d3d11_only &&
+ (IsEqualGUID(riid, &IID_ID3D10Device1)
+ || IsEqualGUID(riid, &IID_ID3D10Device)))
{
*out = &device->ID3D10Device1_iface;
}
@@ -6229,6 +6230,7 @@ void d3d_device_init(struct d3d_device *device, void *outer_unknown)
device->refcount = 1;
/* COM aggregation always takes place */
device->outer_unk = outer_unknown;
+ device->d3d11_only = 0;
d3d11_immediate_context_init(&device->immediate_context, device);
ID3D11DeviceContext1_Release(&device->immediate_context.ID3D11DeviceContext1_iface);
diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c
index 3ae05537a1e7..f4c678217bc1 100644
--- a/dlls/d3d11/tests/d3d11.c
+++ b/dlls/d3d11/tests/d3d11.c
@@ -2110,8 +2110,8 @@ static void test_device_interfaces(const D3D_FEATURE_LEVEL feature_level)
check_interface(device, &IID_IDXGIDevice, TRUE, FALSE);
check_interface(device, &IID_IDXGIDevice1, TRUE, FALSE);
check_interface(device, &IID_ID3D10Multithread, TRUE, TRUE); /* Not available on all Windows versions. */
- todo_wine check_interface(device, &IID_ID3D10Device, FALSE, FALSE);
- todo_wine check_interface(device, &IID_ID3D10Device1, FALSE, FALSE);
+ check_interface(device, &IID_ID3D10Device, FALSE, FALSE);
+ check_interface(device, &IID_ID3D10Device1, FALSE, FALSE);
check_interface(device, &IID_ID3D11InfoQueue, enable_debug_layer, FALSE);
hr = ID3D11Device_QueryInterface(device, &IID_IDXGIDevice, (void **)&dxgi_device);
@@ -2487,7 +2487,7 @@ static void test_texture1d_interfaces(void)
d3d10_device = (ID3D10Device *)0xdeadbeef;
ID3D10Texture1D_GetDevice(d3d10_texture, &d3d10_device);
- todo_wine ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
+ ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
if (d3d10_device) ID3D10Device_Release(d3d10_device);
ID3D10Texture1D_Release(d3d10_texture);
@@ -2884,7 +2884,7 @@ static void test_texture2d_interfaces(void)
d3d10_device = (ID3D10Device *)0xdeadbeef;
ID3D10Texture2D_GetDevice(d3d10_texture, &d3d10_device);
- todo_wine ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
+ ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
if (d3d10_device) ID3D10Device_Release(d3d10_device);
ID3D10Texture2D_Release(d3d10_texture);
@@ -3143,7 +3143,7 @@ static void test_texture3d_interfaces(void)
d3d10_device = (ID3D10Device *)0xdeadbeef;
ID3D10Texture3D_GetDevice(d3d10_texture, &d3d10_device);
- todo_wine ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
+ ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
if (d3d10_device) ID3D10Device_Release(d3d10_device);
ID3D10Texture3D_Release(d3d10_texture);
@@ -3432,7 +3432,7 @@ static void test_create_buffer(void)
d3d10_device = (ID3D10Device *)0xdeadbeef;
ID3D10Buffer_GetDevice(d3d10_buffer, &d3d10_device);
- todo_wine ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
+ ok(!d3d10_device, "Test %u: Got unexpected device pointer %p, expected NULL.\n", i, d3d10_device);
if (d3d10_device) ID3D10Device_Release(d3d10_device);
ID3D10Buffer_Release(d3d10_buffer);
@@ -6592,8 +6592,8 @@ static void test_device_context_state(void)
return;
}
- todo_wine check_interface(device, &IID_ID3D10Device, FALSE, FALSE);
- todo_wine check_interface(device, &IID_ID3D10Device1, FALSE, FALSE);
+ check_interface(device, &IID_ID3D10Device, FALSE, FALSE);
+ check_interface(device, &IID_ID3D10Device1, FALSE, FALSE);
feature_level = ID3D11Device1_GetFeatureLevel(device);
ID3D11Device1_GetImmediateContext1(device, &context);
--
2.26.1
More information about the wine-devel
mailing list