[PATCH] shlwapi: Fix SHRegDuplicateHKey declarations.

[Nikolay Sivov]

On 5/19/20 6:16 PM, Serge Gautherie wrote:
> On 19/05/2020 16:49, Nikolay Sivov wrote:
>
>> On 5/19/20 5:45 PM, Serge Gautherie wrote:
>>> -@ stdcall SHRegDuplicateHKey(long) shlwapi.SHRegDuplicateHKey
>>> +@ stdcall SHRegDuplicateHKey(ptr) shlwapi.SHRegDuplicateHKey
>> This is fine as it is, because argument is a handle.
>
> I am wondering about HKEY > HANDLE > void *.
> Shouldn't handles be declared as pointers in spec files?
> If not, then what about '@ stdcall SHRegCloseUSKey(ptr)' for example?
For relay logs it makes no difference, personally I have no problem with 
using ptr for that, but you're changing what's already there.
>
>> Please don't add such comment headers, most of them were removed during
>> shcore transition.
>
> Noted, I wasn't sure this removal was intended.
>
>>> -HKEY WINAPI SHRegDuplicateHKey(HKEY);
>>> +HKEY WINAPI SHRegDuplicateHKey(IN HKEY hKey);
>> What is this useful for?
>
> There are IN annotations elsewhere in the tree, so why not here too?
>
Sure, if such macros were used by anything we could have more, if it's 
not useful it seems better to have less of it.