[PATCH] user32: Fix NULL dereference in UnregisterDeviceNotification

Zebediah Figura z.figura12 at gmail.com
Wed May 20 09:01:21 CDT 2020

On 5/20/20 7:14 AM, Zhiyi Zhang wrote:
> Hi Arkadiusz,
> Checking NULL is usually fine. But I think you should add the tests to sechost.
> There are also
> https://github.com/ValveSoftware/wine/commit/bbcd2686d599adf6c5cc8e8466ade0b2c2e5f38a
> https://github.com/ValveSoftware/wine/commit/2d5d0a50652e13254fef3d13df14d3b01efda938
> I haven't look at if I_ScUnregisterDeviceNotification() is already fully implemented.
> But if it is not, it would be more useful to get it upstream rather than simply checking NULL.
> If checking NULL is enough to fix a real world application and you think upstreamming
> the work is too much for you then a simple NULL fix is also fine.

Personally, I think the test makes sense where it is.

On the other hand, it'd be nice to mention in the commit message what 
application is fixed by this.

More information about the wine-devel mailing list