[RFC PATCH] strmbase: Allow NULL pin_get_media_type() callback in source_Connect().

Akihiro Sagawa sagawa.aki at gmail.com
Wed May 20 09:36:01 CDT 2020

Hi Zebediah,

I have a question about strmbase. By commit 38f5f364629650cba3ee90f326c2bb4f1c0f19c1,
you made pin_get_media_type() callback optional. However,
source_Connect() in strmbase/pin.c still uses base.pin_get_media_type()
without NULL pointer checks.

Was it done by design or not? If yes, I'll add some workarounds to my
source (actually testsource_ops in dlls/quartz/tests/mpegsplit.c).
If not, please feel free to apply this patch.

Signed-off-by: Akihiro Sagawa <sagawa.aki at gmail.com>
 dlls/strmbase/pin.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-strmbase-Allow-NULL-pin_get_media_type-callback-in-s.patch
Type: text/x-patch
Size: 1345 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200520/7dea3845/attachment.bin>

More information about the wine-devel mailing list