[PATCH] user32: Fix NULL dereference in UnregisterDeviceNotification
rpisl at seznam.cz
Wed May 20 16:19:40 CDT 2020
I have the same fix in my repo and finally spared some time to fill a
bug report: https://bugs.winehq.org/show_bug.cgi?id=49211
Dne 20. 05. 20 v 16:01 Zebediah Figura napsal(a):
> On 5/20/20 7:14 AM, Zhiyi Zhang wrote:
>> Hi Arkadiusz,
>> Checking NULL is usually fine. But I think you should add the tests to
>> There are also
>> I haven't look at if I_ScUnregisterDeviceNotification() is already
>> fully implemented.
>> But if it is not, it would be more useful to get it upstream rather
>> than simply checking NULL.
>> If checking NULL is enough to fix a real world application and you
>> think upstreamming
>> the work is too much for you then a simple NULL fix is also fine.
> Personally, I think the test makes sense where it is.
> On the other hand, it'd be nice to mention in the commit message what
> application is fixed by this.
More information about the wine-devel