[PATCH] ntdll: Use memcpy() in set_float_reg().
Matteo Bruni
mbruni at codeweavers.com
Fri May 22 13:39:59 CDT 2020
The source address might not be aligned although the compiler can
expect alignment when using a plain assignment.
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
---
This avoids random crashes in some embedded versions of Chromium.
dlls/ntdll/signal_x86_64.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c
index 31af1e98d3f..e92470e9606 100644
--- a/dlls/ntdll/signal_x86_64.c
+++ b/dlls/ntdll/signal_x86_64.c
@@ -3298,7 +3298,8 @@ static void set_int_reg( CONTEXT *context, KNONVOLATILE_CONTEXT_POINTERS *ctx_pt
static void set_float_reg( CONTEXT *context, KNONVOLATILE_CONTEXT_POINTERS *ctx_ptr, int reg, M128A *val )
{
- *(&context->u.s.Xmm0 + reg) = *val;
+ /* Use a memcpy() to avoid issues if val is misaligned. */
+ memcpy(&context->u.s.Xmm0 + reg, val, sizeof(*val));
if (ctx_ptr) ctx_ptr->u.FloatingContext[reg] = val;
}
--
2.26.2
More information about the wine-devel
mailing list