[PATCH] msado15: Implement _Command get/put CommandType

[Aaro Altonen]

On Mon, May 25, 2020 at 03:41:46PM +0200, Hans Leidekker wrote:
> On Mon, 2020-05-25 at 16:01 +0300, Aaro Altonen wrote:
> > --- a/dlls/msado15/command.c
> > +++ b/dlls/msado15/command.c
> > @@ -33,6 +33,7 @@ struct command
> >  {
> >      _Command Command_iface;
> >      LONG     ref;
> > +    int      type;
> 
> Why not use CommandTypeEnum here?
> 
fixed
> > --- a/dlls/msado15/tests/msado15.c
> > +++ b/dlls/msado15/tests/msado15.c
> > @@ -742,6 +742,7 @@ static void test_Command(void)
> >      _ADO *ado;
> >      Command15 *command15;
> >      Command25 *command25;
> > +    CommandTypeEnum cmd_type;
> >  
> >      hr = CoCreateInstance( &CLSID_Command, NULL, CLSCTX_INPROC_SERVER, &IID__Command, (void **)&command );
> >      ok( hr == S_OK, "got %08x\n", hr );
> > @@ -758,6 +759,18 @@ static void test_Command(void)
> >      ok( hr == S_OK, "got %08x\n", hr );
> >      Command25_Release( command25 );
> >  
> > +    hr = _Command_get_CommandType( command, &cmd_type );
> > +    ok( hr == S_OK, "got %08x\n", hr );
> > +    ok( cmd_type == adCmdUnknown, "got %08x\n", cmd_type );
> 
> Please set cmd_type to a value different from adCmdUnknown before the
> call.
> 
> 
done

thank you for the feedback

-aaro