[PATCH 07/11] wine/asm.h: Use __ASM_CFI on clang too, despite not defining __GCC_HAVE_DWARF2_CFI_ASM
Martin Storsjö
martin at martin.st
Fri May 29 05:39:49 CDT 2020
On Fri, 29 May 2020, Jacek Caban wrote:
> On 28.05.2020 23:40, Martin Storsjö wrote:
>> On Thu, 28 May 2020, Jacek Caban wrote:
>>
>>> Hi Martin,
>>>
>>> On 28.05.2020 10:14, Martin Storsjo wrote:
>>>> It has already been unconditionally enabled for macOS (which uses clang).
>>>
>>>
>>> Should we use it when building with llvm-mingw and SEH is enabled?
>>
>> Right - if targeting a PE, we should definitely be emitting SEH instead. (I
>> have no idea how to express the fake frames used in the following patch in
>> SEH form though - but I guess there's still some time before the core of
>> ntdll can be built as a PE...)
>>
>> Maybe (defined(__clang__) && defined(__ELF__)) for this then?
>
>
> Maybe (defined(__clang__) && defined(__GNUC__) && !defined(__SEH__))? It
> would take care of macOS as well.
Thanks, that sounds sensible - will send a patch with that soon.
// Martin
More information about the wine-devel
mailing list