[PATCH 4/5] winegstreamer: Set MF_PD_MIME_TYPE on source's presentation descriptor.

Derek Lesho dlesho at codeweavers.com
Mon Nov 2 11:22:44 CST 2020


On 11/2/20 11:13 AM, Zebediah Figura wrote:
> On 11/2/20 11:12 AM, Derek Lesho wrote:
>> On 11/2/20 11:02 AM, Nikolay Sivov wrote:
>>> I have two concerns, or questions:
>>>
>>> - do we always return uncompressed types from winegstreamer source? If
>>> so won't this mime type contradict raw format that it actually returns?
>> Yes, as of right now, all the streams are uncompressed.  The
>> MF_PD_MIME_TYPE attribute on the other hand doesn't specify the type of
>> the streams (after all, it's only set on a per presentation descriptor
>> basis).  I think it's safe to assume it represents the mime type of the
>> input data, which all streams share.  The documentation on this is again
>> lacking.
> Instead of assuming, can't we just write tests?
I mean, yeah, but I'm not sure how useful that would be when real media 
sources always output uncompressed types anyway.  Something useful to 
test though might be whether MF_PD_MIME_TYPE always mirrors 
MF_BYTESTREAM_CONTENT_TYPE.
>
>>> - if we need to return mime attribute, is it possible to get it from
>>> some gstreamer attribute and not from original bytestream attribute,
>>> that occasionally we set automatically?
>> Yes, this should be possible, I would assume it's sent through a tag event.
>>
>



More information about the wine-devel mailing list