[PATCH 1/4] server: Allow named pipes creation with device file as root directory.

[Alexandre Julliard]

Paul Gofman <pgofman at codeweavers.com> writes:

> On 11/11/20 22:16, Paul Gofman wrote:
>> On 11/11/20 22:09, Alexandre Julliard wrote:
>>> Paul Gofman <pgofman at codeweavers.com> writes:
>>>
>>>> @@ -1350,28 +1350,39 @@ DECL_HANDLER(create_named_pipe)
>>>>      struct named_pipe *pipe;
>>>>      struct pipe_server *server;
>>>>      struct unicode_str name;
>>>> -    struct object *root;
>>>> +    struct object *root = NULL;
>>>>      const struct security_descriptor *sd;
>>>> -    const struct object_attributes *objattr = get_req_object_attributes( &sd, &name, &root );
>>>> +    const struct object_attributes *objattr = get_req_object_attributes( &sd, &name, NULL );
>>> It should be possible to make get_req_object_attributes() not require a
>>> directory instead.
>>>
>> Will it be better to pass object ops to get_req_object_attributes() and
>> update the usages accordingly? Possibly allowing NULL which will default
>> to directory.
>>
> Or actually I can better just use get_handle_obj() without specifying
> any ops in get_req_object_attributes().

Yes, that's what I meant. It should fail later when trying to link an
object into something that's not a directory.

-- 
Alexandre Julliard
julliard at winehq.org