[PATCH v2 1/3] include: Add xact2wb.h

[Vijay Kiran Kamuju]

On Mon, Nov 16, 2020 at 10:18 AM Alistair Leslie-Hughes
<leslie_alistair at hotmail.com> wrote:
>
> Hi Vijay,
>
> On 7/11/20 12:42 am, Vijay Kiran Kamuju wrote:
> > Signed-off-by: Vijay Kiran Kamuju <infyquest at gmail.com>
> >
> > +typedef enum WAVEBANKSEGIDX
> > +{
> > +    WAVEBANK_SEGIDX_BANKDATA = 0,
> > +    WAVEBANK_SEGIDX_ENTRYMETADATA,
> > +    WAVEBANK_SEGIDX_SEEKTABLES,
> > +    WAVEBANK_SEGIDX_ENTRYNAMES,
> > +    WAVEBANK_SEGIDX_ENTRYWAVEDATA,
> > +    WAVEBANK_SEGIDX_COUNT
> > +} WAVEBANKSEGIDX, *LPWAVEBANKSEGIDX;
>
> This structure doesn't appear correct, the Dec 2005 SDK header doesn't
> have WAVEBANK_SEGIDX_SEEKTABLES for example.  Please double check.
Dec 2005 SDK is a beta SDK for xactengine,
when you check the beta cab files it will be delivered as xactengine.dll
We can call it as version 1 of xactengine.
I don't know if we can include version checks for beta headers or dlls.
I will try to put the header checks for enums and some structs/unions
>
> > +typedef struct WAVEBANKSAMPLEREGION
> > +{
> > +    DWORD dwStartSample;
> > +    DWORD dwTotalSamples;
> > +} WAVEBANKSAMPLEREGION, *LPWAVEBANKSAMPLEREGION;
>
> This structure doesn't appear either,  guessing we need to add #if
> around where WAVEBANKENTRY is used, to make it compatible with older
> versions.
I will  try to put the header checks for enums and some structs/unions.
But FAudio might fail to interpret the enum or structs for older
versions of xactengine correctly.
>
> Regards
> Alistair