[PATCH v2 3/3] quartz: Only return S_FALSE in IEnumFilters::Skip() if count goes past the end of the sequence.
Gijs Vermeulen
gijsvrm at gmail.com
Mon Nov 23 10:29:28 CST 2020
Signed-off-by: Gijs Vermeulen <gijsvrm at gmail.com>
---
dlls/quartz/filtergraph.c | 2 +-
dlls/quartz/tests/filtergraph.c | 24 ++++++++++++++++++++++++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index b2a1e25600c..c9e26231032 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -331,7 +331,7 @@ static HRESULT WINAPI EnumFilters_Skip(IEnumFilters *iface, ULONG count)
while (count--)
{
if (!(enum_filters->cursor = list_next(&enum_filters->graph->filters, enum_filters->cursor)))
- return S_FALSE;
+ return count ? S_FALSE : S_OK;
}
return S_OK;
diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c
index 9de4919df28..3da089d4915 100644
--- a/dlls/quartz/tests/filtergraph.c
+++ b/dlls/quartz/tests/filtergraph.c
@@ -695,6 +695,30 @@ static void test_enum_filters(void)
hr = IEnumFilters_Reset(enum1);
ok(hr == S_OK, "Got hr %#x.\n", hr);
+ hr = IEnumFilters_Skip(enum1, 0);
+ ok(hr == S_OK, "Got hr %#x.\n", hr);
+
+ hr = IEnumFilters_Skip(enum1, 1);
+ ok(hr == S_OK, "Got hr %#x.\n", hr);
+
+ hr = IEnumFilters_Skip(enum1, 2);
+ ok(hr == S_FALSE, "Got hr %#x.\n", hr);
+
+ hr = IEnumFilters_Skip(enum1, 1);
+ ok(hr == E_INVALIDARG, "Got hr %#x.\n", hr);
+
+ hr = IEnumFilters_Reset(enum1);
+ ok(hr == S_OK, "Got hr %#x.\n", hr);
+
+ hr = IEnumFilters_Skip(enum1, 2);
+ ok(hr == S_OK, "Got hr %#x.\n", hr);
+
+ hr = IEnumFilters_Skip(enum1, 1);
+ ok(hr == E_INVALIDARG, "Got hr %#x.\n", hr);
+
+ hr = IEnumFilters_Reset(enum1);
+ ok(hr == S_OK, "Got hr %#x.\n", hr);
+
hr = IEnumFilters_Next(enum1, 1, filters, NULL);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(filters[0] == filter2, "Got filter %p.\n", filters[0]);
--
2.29.2
More information about the wine-devel
mailing list