[PATCH] shell32/tests: Increase 6 buffers to avoid potential overflows via sprintf (GCC).

Michael Stefaniuc mstefani at winehq.org
Mon Nov 23 15:13:56 CST 2020


Wow! Only 2 years later?
Between my first attempt of introducing ARRAY_SIZE() with an "I'm not convinced"
reply and my standardization of the different ARRAY_SIZE() that others
introduced it took 5+ years.

Wine is just not for visionaries...
/me laughs


You seem to have an interest in compiler development and some of the advanced
warnings turn out to be not that helpful. So there is a reluctance to add
workarounds for those. Once they make it even to Debian then they became a
problem so a fix is more likely to get in even though it is "ugly".


bye
	michael


On 11/22/20 5:29 PM, Gerald Pfeifer wrote:
> This patch of mine in 2018 received a note from Nikolay
> 
>   "I think we should try instead to use more predictable paths. This 
>   change scatters magic increments, that looks worse than a warning 
>   in my opinion."
> 
> as it's only response.  It was not applied.
> 
> Nearly to the day two years later pretty exactly the same patch got
> applied, from a different author:




More information about the wine-devel mailing list