[PATCH vkd3d 2/5] tests: Add some tests for macro expansion.

Matteo Bruni mbruni at codeweavers.com
Tue Nov 24 15:21:08 CST 2020


Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
---
Okay, this is getting into pretty deep madness. Nice tests btw.

I forgot that sometimes D3DPreprocess() returns success and "some"
output even when it reports actual errors. I don't know that we should
also check for those errors (for some value of "check") in the
test. I'd say no until we have a very good reason.

The other side is the sometimes peculiar output of the preprocessor,
in particular WRT macro expansion. Unfortunately we might eventually
want to check the exact output because, as it's invariably the case,
there are applications that depend on it
(https://bugs.winehq.org/show_bug.cgi?id=31701).

Somewhat related, I don't know if it makes sense to add a test option
to dump the output of D3DPreprocess(). Just putting it out there, I
hacked a trace() in the test runner and that's good enough for me
anyway.



More information about the wine-devel mailing list