[PATCH] advapi32/tests: Don't check the display name if not in an English locale.
Francois Gouget
fgouget at codeweavers.com
Mon Nov 30 09:02:28 CST 2020
Service display names are often translated.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
For instance:
service.c:2718: Test failed: got Windows-Ereignisprotokoll
service.c:2718: Test failed: got Journal dévénements Windows
dlls/advapi32/tests/service.c | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c
index d216e096207..cbe7fffbc7a 100644
--- a/dlls/advapi32/tests/service.c
+++ b/dlls/advapi32/tests/service.c
@@ -2678,6 +2678,26 @@ static void test_refcount(void)
CloseServiceHandle(scm_handle);
}
+static BOOL is_lang_english(void)
+{
+ static HMODULE hkernel32 = NULL;
+ static LANGID (WINAPI *pGetThreadUILanguage)(void) = NULL;
+ static LANGID (WINAPI *pGetUserDefaultUILanguage)(void) = NULL;
+
+ if (!hkernel32)
+ {
+ hkernel32 = GetModuleHandleA("kernel32.dll");
+ pGetThreadUILanguage = (void*)GetProcAddress(hkernel32, "GetThreadUILanguage");
+ pGetUserDefaultUILanguage = (void*)GetProcAddress(hkernel32, "GetUserDefaultUILanguage");
+ }
+ if (pGetThreadUILanguage)
+ return PRIMARYLANGID(pGetThreadUILanguage()) == LANG_ENGLISH;
+ if (pGetUserDefaultUILanguage)
+ return PRIMARYLANGID(pGetUserDefaultUILanguage()) == LANG_ENGLISH;
+
+ return PRIMARYLANGID(GetUserDefaultLangID()) == LANG_ENGLISH;
+}
+
static void test_EventLog(void)
{
SC_HANDLE scm_handle, svc_handle;
@@ -2715,7 +2735,8 @@ todo_wine
ok(!strcmp(config->lpServiceStartName, "LocalSystem") /* XP */ ||
!strcmp(config->lpServiceStartName, "NT AUTHORITY\\LocalService"),
"got %s\n", config->lpServiceStartName);
- ok(!strcmp(config->lpDisplayName, "Event Log") /* XP */ ||
+ ok(!is_lang_english() || /* DisplayName is often translated */
+ !strcmp(config->lpDisplayName, "Event Log") /* XP */ ||
!strcmp(config->lpDisplayName, "Windows Event Log") /* Vista+ */, "got %s\n", config->lpDisplayName);
HeapFree(GetProcessHeap(), 0, config);
--
2.20.1
More information about the wine-devel
mailing list