[PATCH] msvfw32/tests: add a few tests for MCIWndCreate

Dmitry Timoshkov dmitry at baikal.ru
Sun Oct 4 03:46:20 CDT 2020


David Adam <david.adam.cnrs at gmail.com> wrote:

>  static void test_MCIWndCreate(void)
>  {
> -    HWND parent, window;
> +    int i;
> +    HWND parent, window, window2;
>      HMODULE hinst = GetModuleHandleA(NULL);
>      char fname[MAX_PATH];
>      char invalid_fname[] = "invalid.avi";
>      char error[200];
>      LRESULT ret;
> +    unsigned long int result;
> +    unsigned long int always_set_style, expected_style, style;
> +    unsigned long int given_style[]= { MCIWNDF_NOAUTOSIZEWINDOW, MCIWNDF_NOAUTOSIZEMOVIE, MCIWNDF_NOMENU,
> +        MCIWNDF_RECORD, MCIWNDF_SHOWMODE, MCIWNDF_SHOWNAME, MCIWNDF_SHOWPOS };

Please try to follow win32 types. Using 'long' is almost always wrong.

-- 
Dmitry.



More information about the wine-devel mailing list