[PATCH] shell32: Fix a leak on error path (Coverity).

Sven Baars sbaars at codeweavers.com
Sun Oct 4 11:10:23 CDT 2020


Signed-off-by: Sven Baars <sbaars at codeweavers.com>
---
 dlls/shell32/shfldr_unixfs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/shell32/shfldr_unixfs.c b/dlls/shell32/shfldr_unixfs.c
index a37b1bf5881..48d5fe4ecb6 100644
--- a/dlls/shell32/shfldr_unixfs.c
+++ b/dlls/shell32/shfldr_unixfs.c
@@ -1251,7 +1251,10 @@ static HRESULT WINAPI ShellFolder2_GetDisplayNameOf(IShellFolder2* iface,
                 LPWSTR pwszDosFileName = wine_get_dos_file_name(This->m_pszPath);
                 if (!pwszDosFileName) return HRESULT_FROM_WIN32(GetLastError());
                 lpName->u.pOleStr = SHAlloc((lstrlenW(pwszDosFileName) + 1) * sizeof(WCHAR));
-                if (!lpName->u.pOleStr) return HRESULT_FROM_WIN32(GetLastError());
+                if (!lpName->u.pOleStr) {
+                    heap_free(pwszDosFileName);
+                    return HRESULT_FROM_WIN32(GetLastError());
+                }
                 lstrcpyW(lpName->u.pOleStr, pwszDosFileName);
                 PathRemoveBackslashW(lpName->u.pOleStr);
                 heap_free(pwszDosFileName);
-- 
2.25.1




More information about the wine-devel mailing list