[PATCH v2 2/3] winevulkan: Implement extension faking mechanism

Liam Middlebrook lmiddlebrook at nvidia.com
Tue Oct 13 19:06:40 CDT 2020


As noted in my initial review of this patch on 2020-07-16:

> 
>>  25 +# List of device extensions to ensure that we support regardless of whether  26 +# the actual driver supports them or not.
> 
> I think for an extension to be "faked" it has to be fully unsupported by the underlying VK implementation. For simplicity I think it makes most sense if this is only used in-practice for platform==win32 extensions.
> 
> Theoretically winevulkan could fake a "normal" extension that's just not available from the current driver, but that seems like a weird path to go down, and I think it would be best to avoid.
> 
> Could the comment be updated to reflect the intended scope of faked extensions?
> 
> It won't matter for this initial implementation/usage, but it's interesting to consider if we want conditional support for faked extensions in the future. 


Thanks,

Liam Middlebrook

On 10/13/20 3:00 PM, Joshua Ashton wrote:
> 
> - Joshie 🐸✨



More information about the wine-devel mailing list