[PATCH v2 3/3] winevulkan: Fake support for, VK_EXT_full_screen_exclusive
Liam Middlebrook
lmiddlebrook at nvidia.com
Tue Oct 13 20:05:40 CDT 2020
From my original review on 2020-07-16:
> It seems like at a minimum there should be some fixme messages for the various VkFullScreenExclusiveEXT values which can be used in conjunction with vkCreateSwapchainKHR, as well as other parts of this extension that we're not really fully supporting, but rather are spoofing to applications which require it.
> - res = thunk_vkGetPhysicalDeviceSurfaceCapabilities2KHR(phys_dev, surface_info, capabilities);
> + /* Toss out VkSurfaceFullScreenExclusiveInfoEXT
> + * and VkSurfaceFullScreenExclusiveWin32InfoEXT
> + *
> + * TODO: Properly convert the pNext chain and don't
> + * unconditionally toss out every element.
> + */
> + surface_info_modified.sType = surface_info->sType;
> + surface_info_modified.pNext = NULL;
> + surface_info_modified.surface = surface_info->surface;
> +
> + res = thunk_vkGetPhysicalDeviceSurfaceCapabilities2KHR(phys_dev, &surface_info_modified, capabilities);
See my reply to PATCH 2/2 in respect to this filtering. However, even if
we needed the filtering, I don't think it would be appropriate to assume
that there only a single pNext entry which just happens to be for
VkSurfaceFullScreenExclusiveInfoEXT and prune the rest of the pNext
chain off.
Thanks,
Liam Middlebrook
On 10/13/20 3:11 PM, Georg Lehmann wrote:
> Signed-off-by: Georg Lehmann <dadschoorse at gmail.com>
>
More information about the wine-devel
mailing list