[PATCH v3 resend 3/4] ntdll: Allow NtQueryVolumeInformationFile to query volume information from the mountmgr.

[Erich E. Hoover]

On Wed, Oct 28, 2020 at 10:33 AM Zebediah Figura <z.figura12 at gmail.com> wrote:
>
> On 9/8/20 3:02 PM, Erich E. Hoover wrote:
> > From 10add5d0acd423e2fb3d762579493dc50f6e6c96 Mon Sep 17 00:00:00 2001
> > From: "Erich E. Hoover" <erich.e.hoover at gmail.com>
> > Date: Fri, 12 Jun 2020 14:53:43 -0600
> > Subject: ntdll: Allow NtQueryVolumeInformationFile to query volume information
> >  from the mountmgr.
>
> Though really this patch is more general than that, i.e. it's actually
> allowing for asynchronous volume information queries from server objects.

I'll update the description.

> For that matter, I don't know what was requested before, but this patch
> split seems a bit awkward. Maybe a better split would be:

The status was just updated to "needs splitting", so I broke the first
patch up into the three you see now.

> 0001: allow volume information queries to be asynchronous (including
> both the changes to server/fd.c and ntdll/unix/file.c, although maybe
> even those should be split...)
> 0002: implement volume information queries for device files
> 0003: hook up volume information queries for mountmgr

Okay, what I think that you're saying is:
0001: server/fd.c changes
0002: ntdll/unix/file.c changes
0003: ntoskrnl.exe/ntoskrnl.c changes
0004: mountmgr.sys/device.c changes
Please let me know if that sounds right to you, I'd be happy to do that.

> As a further note, some simple tests (in dlls/ntoskrnl.exe/tests) could
> help this series.

I'll put that together.

Best,
Erich