[PATCH 5/6] oleaut32: Fix error handling/reporting in TLB_copy_all_custdata.
Kevin Puetz
PuetzKevinA at JohnDeere.com
Thu Oct 29 22:02:08 CDT 2020
VariantCopy clears existing contents of pvargDest and thus requires
it contain a valid (possibly-empty) VARIANT, not uninitialized garbage.
If a failure still occurs, propgate the HRESULT to GetAll*CustData.
Signed-off-by: Kevin Puetz <PuetzKevinA at JohnDeere.com>
---
dlls/oleaut32/typelib.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
index 989340de9c2..d04e4d2cbe2 100644
--- a/dlls/oleaut32/typelib.c
+++ b/dlls/oleaut32/typelib.c
@@ -5288,6 +5288,7 @@ static HRESULT TLB_copy_all_custdata(const struct list *custdata_list, CUSTDATA
TLBCustData *pCData;
unsigned int ct;
CUSTDATAITEM *cdi;
+ HRESULT hr = S_OK;
ct = list_count(custdata_list);
@@ -5300,11 +5301,13 @@ static HRESULT TLB_copy_all_custdata(const struct list *custdata_list, CUSTDATA
cdi = pCustData->prgCustData;
LIST_FOR_EACH_ENTRY(pCData, custdata_list, TLBCustData, entry){
cdi->guid = *TLB_get_guid_null(pCData->guid);
- VariantCopy(&cdi->varValue, &pCData->data);
+ VariantInit(&cdi->varValue);
+ hr = VariantCopy(&cdi->varValue, &pCData->data);
+ if(FAILED(hr)) break;
++cdi;
}
- return S_OK;
+ return hr;
}
More information about the wine-devel
mailing list