[PATCH 2/4] ntdll: Avoid taking loader lock in LdrGetProcedureAddress().

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=81270

Your paranoid android.


=== w1064v1809 (64 bit report) ===

kernel32:
loader.c:709: Test failed: 1197: wrong status c000011b/c0000130
loader.c:709: Test failed: 1202: wrong status c000011b/c0000130
loader.c:709: Test failed: 1207: wrong status c000011b/c000007b
loader.c:709: Test failed: 1212: wrong status c000011b/c000007b
loader.c:709: Test failed: 1217: wrong status c000011b/c000007b
loader.c:709: Test failed: 1222: wrong status c000011b/c000007b
loader.c:709: Test failed: 1227: wrong status c000011b/c000007b
loader.c:709: Test failed: 1243: wrong status c000011b/0
loader.c:709: Test failed: 1247: wrong status c000011b/0
loader.c:709: Test failed: 1252: wrong status c000011b/0
loader.c:709: Test failed: 1256: wrong status c000011b/0
loader.c:709: Test failed: 1260: wrong status c000011b/0

=== w10pro64_ja (64 bit report) ===

kernel32:
loader.c:709: Test failed: 1175: wrong status c000012f/c000011b
loader.c:709: Test failed: 1180: wrong status c000012f/c000011b
loader.c:709: Test failed: 1180: wrong status c000012f/c000011b
loader.c:709: Test failed: 1180: wrong status c000012f/c0000131
loader.c:709: Test failed: 1180: wrong status c000012f/c000011b

=== debiant (32 bit report) ===

kernel32:
loader.c:3965: Test failed: ntdll.dll:0: wrong OptionalHeader.AddressOfEntryPoint 5f780 / 5f730
loader.c:3969: Test failed: ntdll.dll:0: wrong OptionalHeader.DataDirectory[i].VirtualAddress 75000 / 74000
loader.c:3969: Test failed: ntdll.dll:1: wrong OptionalHeader.DataDirectory[i].VirtualAddress 89000 / 88000
loader.c:3969: Test failed: ntdll.dll:2: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8a000 / 89000
loader.c:3969: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8b000 / 8a000
loader.c:3970: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].Size 3b30 / 3b10
loader.c:3975: Test failed: ntdll.dll: wrong section 0
loader.c:3975: Test failed: ntdll.dll: wrong section 1
loader.c:3975: Test failed: ntdll.dll: wrong section 3
loader.c:3975: Test failed: ntdll.dll: wrong section 4
loader.c:3975: Test failed: ntdll.dll: wrong section 5
loader.c:3975: Test failed: ntdll.dll: wrong section 6
loader.c:3975: Test failed: ntdll.dll: wrong section 7
loader.c:3975: Test failed: ntdll.dll: wrong section 8
loader.c:3975: Test failed: ntdll.dll: wrong section 9
loader.c:3975: Test failed: ntdll.dll: wrong section 10
loader.c:3975: Test failed: ntdll.dll: wrong section 11
loader.c:3975: Test failed: ntdll.dll: wrong section 12
loader.c:3975: Test failed: ntdll.dll: wrong section 13
loader.c:3975: Test failed: ntdll.dll: wrong section 14
loader.c:3975: Test failed: ntdll.dll: wrong section 15

=== debiant (32 bit French report) ===

kernel32:
loader.c:3965: Test failed: ntdll.dll:0: wrong OptionalHeader.AddressOfEntryPoint 5f780 / 5f730
loader.c:3969: Test failed: ntdll.dll:0: wrong OptionalHeader.DataDirectory[i].VirtualAddress 75000 / 74000
loader.c:3969: Test failed: ntdll.dll:1: wrong OptionalHeader.DataDirectory[i].VirtualAddress 89000 / 88000
loader.c:3969: Test failed: ntdll.dll:2: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8a000 / 89000
loader.c:3969: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8b000 / 8a000
loader.c:3970: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].Size 3b30 / 3b10
loader.c:3975: Test failed: ntdll.dll: wrong section 0
loader.c:3975: Test failed: ntdll.dll: wrong section 1
loader.c:3975: Test failed: ntdll.dll: wrong section 3
loader.c:3975: Test failed: ntdll.dll: wrong section 4
loader.c:3975: Test failed: ntdll.dll: wrong section 5
loader.c:3975: Test failed: ntdll.dll: wrong section 6
loader.c:3975: Test failed: ntdll.dll: wrong section 7
loader.c:3975: Test failed: ntdll.dll: wrong section 8
loader.c:3975: Test failed: ntdll.dll: wrong section 9
loader.c:3975: Test failed: ntdll.dll: wrong section 10
loader.c:3975: Test failed: ntdll.dll: wrong section 11
loader.c:3975: Test failed: ntdll.dll: wrong section 12
loader.c:3975: Test failed: ntdll.dll: wrong section 13
loader.c:3975: Test failed: ntdll.dll: wrong section 14
loader.c:3975: Test failed: ntdll.dll: wrong section 15

=== debiant (32 bit Japanese:Japan report) ===

kernel32:
loader.c:3965: Test failed: ntdll.dll:0: wrong OptionalHeader.AddressOfEntryPoint 5f780 / 5f730
loader.c:3969: Test failed: ntdll.dll:0: wrong OptionalHeader.DataDirectory[i].VirtualAddress 75000 / 74000
loader.c:3969: Test failed: ntdll.dll:1: wrong OptionalHeader.DataDirectory[i].VirtualAddress 89000 / 88000
loader.c:3969: Test failed: ntdll.dll:2: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8a000 / 89000
loader.c:3969: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8b000 / 8a000
loader.c:3970: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].Size 3b30 / 3b10
loader.c:3975: Test failed: ntdll.dll: wrong section 0
loader.c:3975: Test failed: ntdll.dll: wrong section 1
loader.c:3975: Test failed: ntdll.dll: wrong section 3
loader.c:3975: Test failed: ntdll.dll: wrong section 4
loader.c:3975: Test failed: ntdll.dll: wrong section 5
loader.c:3975: Test failed: ntdll.dll: wrong section 6
loader.c:3975: Test failed: ntdll.dll: wrong section 7
loader.c:3975: Test failed: ntdll.dll: wrong section 8
loader.c:3975: Test failed: ntdll.dll: wrong section 9
loader.c:3975: Test failed: ntdll.dll: wrong section 10
loader.c:3975: Test failed: ntdll.dll: wrong section 11
loader.c:3975: Test failed: ntdll.dll: wrong section 12
loader.c:3975: Test failed: ntdll.dll: wrong section 13
loader.c:3975: Test failed: ntdll.dll: wrong section 14
loader.c:3975: Test failed: ntdll.dll: wrong section 15

=== debiant (32 bit Chinese:China report) ===

kernel32:
loader.c:3965: Test failed: ntdll.dll:0: wrong OptionalHeader.AddressOfEntryPoint 5f780 / 5f730
loader.c:3969: Test failed: ntdll.dll:0: wrong OptionalHeader.DataDirectory[i].VirtualAddress 75000 / 74000
loader.c:3969: Test failed: ntdll.dll:1: wrong OptionalHeader.DataDirectory[i].VirtualAddress 89000 / 88000
loader.c:3969: Test failed: ntdll.dll:2: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8a000 / 89000
loader.c:3969: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8b000 / 8a000
loader.c:3970: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].Size 3b30 / 3b10
loader.c:3975: Test failed: ntdll.dll: wrong section 0
loader.c:3975: Test failed: ntdll.dll: wrong section 1
loader.c:3975: Test failed: ntdll.dll: wrong section 3
loader.c:3975: Test failed: ntdll.dll: wrong section 4
loader.c:3975: Test failed: ntdll.dll: wrong section 5
loader.c:3975: Test failed: ntdll.dll: wrong section 6
loader.c:3975: Test failed: ntdll.dll: wrong section 7
loader.c:3975: Test failed: ntdll.dll: wrong section 8
loader.c:3975: Test failed: ntdll.dll: wrong section 9
loader.c:3975: Test failed: ntdll.dll: wrong section 10
loader.c:3975: Test failed: ntdll.dll: wrong section 11
loader.c:3975: Test failed: ntdll.dll: wrong section 12
loader.c:3975: Test failed: ntdll.dll: wrong section 13
loader.c:3975: Test failed: ntdll.dll: wrong section 14
loader.c:3975: Test failed: ntdll.dll: wrong section 15

=== debiant (32 bit WoW report) ===

kernel32:
loader.c:3965: Test failed: ntdll.dll:0: wrong OptionalHeader.AddressOfEntryPoint 5f780 / 5f730
loader.c:3969: Test failed: ntdll.dll:0: wrong OptionalHeader.DataDirectory[i].VirtualAddress 75000 / 74000
loader.c:3969: Test failed: ntdll.dll:1: wrong OptionalHeader.DataDirectory[i].VirtualAddress 89000 / 88000
loader.c:3969: Test failed: ntdll.dll:2: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8a000 / 89000
loader.c:3969: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8b000 / 8a000
loader.c:3970: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].Size 3b30 / 3b10
loader.c:3975: Test failed: ntdll.dll: wrong section 0
loader.c:3975: Test failed: ntdll.dll: wrong section 1
loader.c:3975: Test failed: ntdll.dll: wrong section 3
loader.c:3975: Test failed: ntdll.dll: wrong section 4
loader.c:3975: Test failed: ntdll.dll: wrong section 5
loader.c:3975: Test failed: ntdll.dll: wrong section 6
loader.c:3975: Test failed: ntdll.dll: wrong section 7
loader.c:3975: Test failed: ntdll.dll: wrong section 8
loader.c:3975: Test failed: ntdll.dll: wrong section 9
loader.c:3975: Test failed: ntdll.dll: wrong section 10
loader.c:3975: Test failed: ntdll.dll: wrong section 11
loader.c:3975: Test failed: ntdll.dll: wrong section 12
loader.c:3975: Test failed: ntdll.dll: wrong section 13
loader.c:3975: Test failed: ntdll.dll: wrong section 14
loader.c:3975: Test failed: ntdll.dll: wrong section 15

ntdll:
threadpool.c:1904: Test failed: WaitForSingleObject returned 258

=== debiant (64 bit WoW report) ===

kernel32:
loader.c:3965: Test failed: ntdll.dll:0: wrong OptionalHeader.AddressOfEntryPoint 5f780 / 5f730
loader.c:3969: Test failed: ntdll.dll:0: wrong OptionalHeader.DataDirectory[i].VirtualAddress 75000 / 74000
loader.c:3969: Test failed: ntdll.dll:1: wrong OptionalHeader.DataDirectory[i].VirtualAddress 89000 / 88000
loader.c:3969: Test failed: ntdll.dll:2: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8a000 / 89000
loader.c:3969: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].VirtualAddress 8b000 / 8a000
loader.c:3970: Test failed: ntdll.dll:5: wrong OptionalHeader.DataDirectory[i].Size 3b30 / 3b10
loader.c:3975: Test failed: ntdll.dll: wrong section 0
loader.c:3975: Test failed: ntdll.dll: wrong section 1
loader.c:3975: Test failed: ntdll.dll: wrong section 3
loader.c:3975: Test failed: ntdll.dll: wrong section 4
loader.c:3975: Test failed: ntdll.dll: wrong section 5
loader.c:3975: Test failed: ntdll.dll: wrong section 6
loader.c:3975: Test failed: ntdll.dll: wrong section 7
loader.c:3975: Test failed: ntdll.dll: wrong section 8
loader.c:3975: Test failed: ntdll.dll: wrong section 9
loader.c:3975: Test failed: ntdll.dll: wrong section 10
loader.c:3975: Test failed: ntdll.dll: wrong section 11
loader.c:3975: Test failed: ntdll.dll: wrong section 12
loader.c:3975: Test failed: ntdll.dll: wrong section 13
loader.c:3975: Test failed: ntdll.dll: wrong section 14
loader.c:3975: Test failed: ntdll.dll: wrong section 15