[PATCH v3] msvcirt: Implement most of ifstream.

[Gijs Vermeulen]

Hi Piotr, Arkadiusz,

Wouldn't it be better to have the out of memory message be WARN or ERR?

Kind regards,
Gijs

Op wo 2 sep. 2020 om 18:31 schreef Piotr Caban <piotr at codeweavers.com>:

> On 9/2/20 6:13 PM, Arkadiusz Hiler wrote:
> > +/* ?attach at ifstream@@QAEXH at Z */
> > +/* ?attach at ifstream@@QEAAXH at Z */
> > +DEFINE_THISCALL_WRAPPER(ifstream_attach, 8)
> > +void __thiscall ifstream_attach(istream *this, filedesc fd)
> > +{
> > +    TRACE("(%p %d)\n", this, fd);
> > +    if (filebuf_attach(ifstream_rdbuf(this), fd) == NULL)
> > +        ios_clear(istream_get_ios(this), IOSTATE_failbit);
> The function should add failbit flag to current state (it shouldn't e.g.
> clear eof state). The same applies to all cases where failbit is set.
>
> Thanks,
> Piotr
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200902/386cae3c/attachment.htm>