[PATCH v2 5/6] msscript.ocx: Return S_OK from the IActiveScriptSiteWindow::EnableModeless stub.

Gabriel Ivăncescu gabrielopcode at gmail.com
Thu Sep 3 09:50:25 CDT 2020


This is needed so e.g. vbscript can display message boxes when used from
the script control.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---
 dlls/msscript.ocx/msscript.c       | 4 ++--
 dlls/msscript.ocx/tests/msscript.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/msscript.ocx/msscript.c b/dlls/msscript.ocx/msscript.c
index a617634..7ddcb8f 100644
--- a/dlls/msscript.ocx/msscript.c
+++ b/dlls/msscript.ocx/msscript.c
@@ -775,9 +775,9 @@ static HRESULT WINAPI ActiveScriptSiteWindow_EnableModeless(IActiveScriptSiteWin
 {
     ScriptHost *This = impl_from_IActiveScriptSiteWindow(iface);
 
-    FIXME("(%p, %d)\n", This, enable);
+    FIXME("(%p, %d): stub\n", This, enable);
 
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static const IActiveScriptSiteWindowVtbl ActiveScriptSiteWindowVtbl = {
diff --git a/dlls/msscript.ocx/tests/msscript.c b/dlls/msscript.ocx/tests/msscript.c
index 2df85ff..e6d139f 100644
--- a/dlls/msscript.ocx/tests/msscript.c
+++ b/dlls/msscript.ocx/tests/msscript.c
@@ -2000,9 +2000,9 @@ static void test_SitehWnd(void)
         ok(window == hwnd, "got %p, expected %p\n", window, hwnd);
 
         hr = IActiveScriptSiteWindow_EnableModeless(site_window, FALSE);
-        todo_wine ok(hr == S_OK, "got 0x%08x\n", hr);
+        ok(hr == S_OK, "got 0x%08x\n", hr);
         hr = IActiveScriptSiteWindow_EnableModeless(site_window, TRUE);
-        todo_wine ok(hr == S_OK, "got 0x%08x\n", hr);
+        ok(hr == S_OK, "got 0x%08x\n", hr);
 
         site_hwnd = 0xdeadbeef;
         hr = IScriptControl_put_SitehWnd(sc, 0);
-- 
2.21.0




More information about the wine-devel mailing list