[PATCH v3] ws2_32: Very minimal support for AF_UNIX.

Richard W.M. Jones rjones at redhat.com
Tue Sep 8 12:39:46 CDT 2020


On Tue, Sep 08, 2020 at 12:27:12PM -0500, Zebediah Figura wrote:
> On 9/8/20 12:12 PM, Richard W.M. Jones wrote:
> > I haven't added any tests yet as the wine/dlls/ws2_32/tests/sock.c
> > fiile is rather daunting.
> 
> It's large, yes, which can be annoying, but in theory the test functions
> should all be independent of each other. Hence you'd just need to add a
> new test function that exercises basic usage of AF_UNIX sockets.

For sure.  I'll try to get round to it once I've done
a bit more testing of AF_UNIX sockets on real Windows.

Rich.

> > 
> > However it does fix a signficant bug - I forgot to translate the
> > filename in the sun_path field from a Windows name to a Unix name.
> > This happened to work by accident with my server which was setting a
> > relative path here, but as soon as I used an absolute path for the
> > socket it revealed the bug in my Wine patch.
> > 
> > Rich.
> > 
> > 
> > 
> 




-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW




More information about the wine-devel mailing list