[PATCH v2 2/2] winevulkan: Add registry key for manipulating quirks

Brendan Shanks bshanks at codeweavers.com
Tue Sep 8 15:22:51 CDT 2020


Hi Liam,

> On Sep 8, 2020, at 12:46 PM, Liam Middlebrook <lmiddlebrook at nvidia.com> wrote:
> 
> Tested with Vulkan CTS and WINEVULKAN_QUIRK_IGNORE_EXPLICIT_LAYERS.
> 
> Signed-off-by: Liam Middlebrook <lmiddlebrook at nvidia.com>
> Signed-off-by: Daniel Koch <dkoch at nvidia.com>
> ---
> v2: fixup comment style
> 
> dlls/winevulkan/vulkan.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> 
> diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c
> index a8beef126bd..19093d47390 100644
> --- a/dlls/winevulkan/vulkan.c
> +++ b/dlls/winevulkan/vulkan.c
> @@ -662,6 +662,7 @@ VkResult WINAPI wine_vkCreateInstance(const VkInstanceCreateInfo *create_info,
>     const VkApplicationInfo *app_info;
>     struct VkInstance_T *object;
>     VkResult res;
> +    HKEY key;
> 
>     TRACE("create_info %p, allocator %p, instance %p\n", create_info, allocator, instance);
> 
> @@ -679,6 +680,22 @@ VkResult WINAPI wine_vkCreateInstance(const VkInstanceCreateInfo *create_info,
>     }
>     object->base.loader_magic = VULKAN_ICD_MAGIC_VALUE;
> 
> +    /* Load optional WineVulkan quirks bits from registry, see vulkan_private.h
> +     * for a list of quirks.
> +     */

There’s a specially-formatted comment that is used to highlight Wine registry keys, like:

/* @@ Wine registry key: HKCU\Software\Wine\Vulkan */

Also, this seems like a good fit to support AppDefaults in the registry.

Thanks,
Brendan


More information about the wine-devel mailing list