[PATCH v4] quartz: Fix crash when pVisible is NULL.

Jactry Zeng jzeng at codeweavers.com
Wed Sep 9 00:40:40 CDT 2020


Hi Pengpeng,

On 9/9/20 1:07 PM, Pengpeng Dong wrote:
> BaseControlWindowImpl_get_Visible(IVideoWindow *iface, LONG *visi
>  
>      TRACE("window %p, visible %p.\n", window, visible);
>  
> +    if(!visible)
> +        return E_POINTER;

Just a nitpick, please add a space after 'if'.
Also, IMO, a commit comment like "quartz: Handle NULL visible in IVideoWindow::get_Visible()." might be better. At least, we don't use 'pVisible' as its parameter name anymore.

Thanks for your contribution.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x9B28F09E873060F4.asc
Type: application/pgp-keys
Size: 3666 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200909/ca65f1a7/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200909/ca65f1a7/attachment.sig>


More information about the wine-devel mailing list