[PATCH resend] ws2_32: Avoid depending on system getservby(name|port) functions

Alex Henrie alexhenrie24 at gmail.com
Fri Sep 11 11:45:27 CDT 2020


On Fri, Sep 11, 2020 at 1:53 AM Alexandre Julliard <julliard at winehq.org> wrote:
>
> Alex Henrie <alexhenrie24 at gmail.com> writes:
>
> > Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> > ---
> > These functions are incredibly slow on Windows. To avoid timeouts, I had
> > to put the tests in protocol.c rather than the crowded sock.c.
>
> The right way to avoid timeouts is to make the test faster. It doesn't
> seem necessary to call these functions thousands of times.

Okay. Which getservbyport tests should I drop? Maybe only test that
the ports we expect to be defined are defined and not test that the
parts we expect to not be defined are not defined?

Alternatively, I could ask Jeremy to buy new, faster hardware for the
testbot VMs.

-Alex



More information about the wine-devel mailing list