[PATCH 5/5] wmphoto: Implement WmpDecoder class using jxrlib.

[Rémi Bernon]

On 2020-09-12 18:24, Esme Povirk (they/them) wrote:
> The testbot failures will need to be addressed, of course.
> 
> d3dx10:d3dx10 has a todo for this:
> d3dx10.c:1380: Test succeeded inside todo block: Test 27: Got unexpected hr 0.
> 
Yes, also I saw that the tests aren't passing on windows 2008, probably 
there isn't wmphoto.dll there.

> While we don't have to support multiple frames for an initial
> implementation, putting the frame object in the same struct as the
> decoder means someone will have to split them out later. Since this
> will become more difficult as the implemenation develops, I'd much
> rather have it done from the start.
> 

Sure.

> This is effectively reimplementing copy_pixels from windowscodecs.
> Maybe we can split it into another file that can be shared with
> wmphoto?
> 

I didn't see that function, could be handy indeed.

Thanks!
-- 
Rémi Bernon <rbernon at codeweavers.com>