[PATCH 4/5] ws2_32: Reimplement WSASocketW() on top of NtOpenFile() and IOCTL_AFD_CREATE.

[Zebediah Figura]

On 9/13/20 3:21 AM, Jacek Caban wrote:
> Hi Zebediah,
> 
> 
> On 12/09/2020 18:10, Zebediah Figura wrote:
>> +        if (err == WSAEACCES) /* raw socket denied */
>> +        {
>> +            if (type == SOCK_RAW)
>> +                ERR_(winediag)("Failed to create a socket of type
>> SOCK_RAW, this requires special permissions.\n");
>> +            else
>> +                ERR_(winediag)("Failed to create socket, this
>> requires special permissions.\n");
>> +        }
> 
> 
> Shouldn't this be part of init ioctl error handling instead?

Yes, thanks for catching that.

> 
> 
>> +        WSASetLastError(err);
>> +        return INVALID_SOCKET;
>>       }
>> -    SERVER_END_REQ;
>> -    if (ret)
>> +
>> +    create_params.family = unixaf;
>> +    create_params.type = unixtype;
>> +    create_params.protocol = protocol;
>> +    create_params.flags = flags & ~WSA_FLAG_NO_HANDLE_INHERIT;
> 
> 
> It may probably be taken care later, but note that it would eventually
> need to pass Windows variant of family and type instead. PE modules
> should not need to know host values.

Yes, to be sure; it's a bit orthogonal to this patch, but I will put it
on the list.

> 
> 
> Thanks,
> 
> Jacek
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200914/2fb44471/attachment-0001.sig>