[PATCH v4 1/3] shell32: Add ShellLinkObject stubs.

Nikolay Sivov nsivov at codeweavers.com
Mon Sep 14 15:14:19 CDT 2020


Yes, it's okay to return this stub from GetLink() in a first patch. Next
you can add internal IShellLink with corresponding IPersistFile
initialization.

Just make sure you don't add dead code or introduce test failures at any
point.

On 9/14/20 11:06 PM, Myah Caron wrote:
> The stubs are unused in this patch, but the later patches do use them. There are no warnings when all 3 patches are applied (at least on my end).
>
> If this is an issue, could you advise a way I could work around this? Would merging #2 with #1 be acceptable? I'd be worried about making this patch too monolithic by doing that though.
>
> Thanks again for reviewing these!
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Monday, September 14, 2020 12:47 PM, Nikolay Sivov <nsivov at codeweavers.com> wrote:
>
>> New stubs are still not used, but in addition to that it will give
>> unused variable warning now.
>




More information about the wine-devel mailing list